Fix Helper aggregation-initialization report-replayed check. #3143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we now check only if the corresponding row exists in the
client_reports
table, rather than ignoring that fact and looking for a correspondingreport_aggregations
row. This means we no longer respect whether the other aggregation used a different aggregation parameter, but that's fine -- Janus now supports only a single aggregation per report.This fixes a few bugs:
check_other_report_aggregation_exists
mistakenly expected at most a single matchingreport_aggregations
row to exist.